netdev - Re: [PATCHv2 2/2] IPVS: Add genetlink interface implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4845fc0807251539w6fe4347dref663f07794cf45c@mail.gmail.com>
Date:	Sat, 26 Jul 2008 00:39:10 +0200
From:	"Julius Volz" <juliusv@...gle.com>
To:	"Thomas Graf" <tgraf@...g.ch>
Cc:	netdev@...r.kernel.org, lvs-devel@...r.kernel.org,
	horms@...ge.net.au, kaber@...sh.net, davem@...emloft.net,
	vbusam@...gle.com
Subject: Re: [PATCHv2 2/2] IPVS: Add genetlink interface implementation

On Fri, Jul 25, 2008 at 1:58 AM, Thomas Graf <tgraf@...g.ch> wrote:
> * Julius Volz <juliusv@...gle.com> 2008-07-21 15:02
>> +static int ip_vs_genl_parse_dest(struct ip_vs_dest_user *udest,
>> +                              struct nlattr *nla, int full_entry)
>> +{
>> +     struct nlattr *attrs[IPVS_SVC_ATTR_MAX + 1];
>> +     struct nlattr *nla_addr, *nla_port;
>> +
>> +     /* Parse mandatory identifying destination fields first */
>> +     if (nla == NULL ||
>> +         nla_parse_nested(attrs, IPVS_DEST_ATTR_MAX, nla, ip_vs_dest_policy))
>
> Small typo here, attrs[] is defined with a length of IPVS_SVC_ATTR_MAX+1
> while IPVS_DEST_ATTR_MAX is passed to to nla_parse_nested.

Right, thanks for catching this! Will include this in the next
iteration after vacation...

Julius

-- 
Google Switzerland GmbH
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html