netdev - Re: [PATCH v2 2/3] net_sched: Add accessor function for packet length for qdiscs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080725125414.GB25369@ff.dom.local>
Date:	Fri, 25 Jul 2008 12:54:15 +0000
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Jussi Kivilinna <jussi.kivilinna@...et.fi>
Cc:	David Miller <davem@...emloft.net>, kaber@...sh.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH v2 2/3] net_sched: Add accessor function for packet
	length for qdiscs

On Fri, Jul 25, 2008 at 03:29:32PM +0300, Jussi Kivilinna wrote:
> Quoting "Jarek Poplawski" <jarkao2@...il.com>:
>
>> OK, I see htb did this earlier with ".packets", so it looks like I'm
>> wrong with this - sorry! (Anyway, it seems to unnecessarily restrict
>> the way qdisc are working.)
>>
>
> Would it be better for qdisc_enqueue() to pass packet length to caller?
>

Is it's really needed? Actually, if it's only for stats, I really
can't see the reason why not to get this info old way - before
enqueing? (And this could be not enough if we want packets count
like in htb.)

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html