netdev - Re: [PATCH 2/3] net: convert BUG_TRAP to generic WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1KMPJS-0005Dh-00@gondolin.me.apana.org.au>
Date:	Fri, 25 Jul 2008 23:34:34 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	ilpo.jarvinen@...sinki.fi (Ilpo J??rvinen)
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	ilpo.jarvinen@...sinki.fi
Subject: Re: [PATCH 2/3] net: convert BUG_TRAP to generic WARN_ON

Ilpo J??rvinen <ilpo.jarvinen@...sinki.fi> wrote:
>
> diff --git a/net/ipv4/ipcomp.c b/net/ipv4/ipcomp.c
> index a75807b..ee1bbf9 100644
> --- a/net/ipv4/ipcomp.c
> +++ b/net/ipv4/ipcomp.c
> @@ -293,7 +293,7 @@ static void ipcomp_free_tfms(struct crypto_comp **tfms)
>                        break;
>        }
> 
> -       BUG_TRAP(pos);
> +       WARN_ON(!pos);

Sorry I've just moved this to net/xfrm/xfrm_ipcomp.c.  BTW,
please also remove rtnetlink.h from ipcomp.c since that's only
included for this macro.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html