netdev - Re: [PATCH] netns: fix ip_rt_frag_needed rt_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1217090252.6549.4.camel@iris.sw.ru>
Date:	Sat, 26 Jul 2008 20:37:32 +0400
From:	"Denis V. Lunev" <den@...nvz.org>
To:	Hugh Dickins <hugh@...itas.com>
Cc:	David Miller <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netns: fix ip_rt_frag_needed rt_is_expired

Acked-by: Denis V. Lunev <den@...nvz.org>

Thanks for founding this issue...

On Sat, 2008-07-26 at 13:48 +0100, Hugh Dickins wrote:
> Running recent kernels, and using a particular vpn gateway, I've been
> having to edit my mails down to get them accepted by the smtp server.
> 
> Git bisect led to commit e84f84f276473dcc673f360e8ff3203148bdf0e2 -
> netns: place rt_genid into struct net.  The conversion from a != test
> to rt_is_expired() put one negative too many: and now my mail works.
> 
> Signed-off-by: Hugh Dickins <hugh@...itas.com>
> ---
> Ingo was having strange distcc problems, might this help him too?
> 
>  net/ipv4/route.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- 2.6.26-git/net/ipv4/route.c	2008-07-26 12:31:50.000000000 +0100
> +++ linux/net/ipv4/route.c	2008-07-26 13:10:04.000000000 +0100
> @@ -1502,7 +1502,7 @@ unsigned short ip_rt_frag_needed(struct 
>  				    rth->fl.iif != 0 ||
>  				    dst_metric_locked(&rth->u.dst, RTAX_MTU) ||
>  				    !net_eq(dev_net(rth->u.dst.dev), net) ||
> -				    !rt_is_expired(rth))
> +				    rt_is_expired(rth))
>  					continue;
>  
>  				if (new_mtu < 68 || new_mtu >= old_mtu) {

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html