netdev - Re: [PATCH 1/3] Blackfin EMAC Driver: add proper __devinit/_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 27 Jul 2008 22:46:38 +0800
From:	"Bryan Wu" <cooloney@...nel.org>
To:	"Mike Frysinger" <vapier.adi@...il.com>
Cc:	jeff@...zik.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH 1/3] Blackfin EMAC Driver: add proper __devinit/__devexit markings

On Sun, Jul 27, 2008 at 9:03 PM, Mike Frysinger <vapier.adi@...il.com> wrote:
> On Sun, Jul 27, 2008 at 2:13 AM, Bryan Wu wrote:
>> From: Mike Frysinger <vapier.adi@...il.com>
>>
>> Signed-off-by: Mike Frysinger <vapier.adi@...il.com>
>> Signed-off-by: Bryan Wu <cooloney@...nel.org>
>> ---
>>  drivers/net/bfin_mac.c |    8 ++++----
>>  1 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c
>> index 4144343..e18a7ee 100644
>> --- a/drivers/net/bfin_mac.c
>> +++ b/drivers/net/bfin_mac.c
>> @@ -614,7 +614,7 @@ static int bfin_mac_hard_start_xmit(struct sk_buff *skb,
>>         * Is skb->data always 16-bit aligned?
>>         * Do we need to memcpy((char *)(tail->packet + 2), skb->data, len)?
>>         */
>> -       if ((((unsigned int)(skb->data)) & 0x02) == 2) {
>> +       if ((((unsigned int)(skb->data)) & 0x01) == 0) {
>>                /* move skb->data to current_tx_ptr payload */
>>                data = (unsigned int)(skb->data) - 2;
>>                *((unsigned short *)data) = (unsigned short)(skb->len);
>
> i think this unrelated hunk slipped in
> -mike
>

Oops, I messed up something. Fixed now.

Thanks,
-Bryan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html