netdev - Re: [PATCH] typhoon: use request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1217248585.22789.58.camel@obelisk.thedillows.org>
Date:	Mon, 28 Jul 2008 08:36:25 -0400
From:	David Dillow <dave@...dillows.org>
To:	Jaswinder Singh <jaswinder@...radead.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, becker@...ld.com,
	davidpmclean@...oo.com, Jeff Garzik <jeff@...zik.org>,
	netdev <netdev@...r.kernel.org>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH] typhoon: use request_firmware

On Mon, 2008-07-28 at 08:46 +0530, Jaswinder Singh wrote:
> On Sun, 2008-07-27 at 21:43 -0400, David Dillow wrote:
> > It is not quite this simple. By not loading the firmware on device
> > probe, you have opened the door to a broken resume, and the driver will
> > now try to sleep in an atomic context, when typhoon_tx_timeout() is
> > called at the very least.
> > 
> 
> I just added the request_firmware support and
> replaced typhoon_firmware_image with fw->data.
> I do not think this will make any difference in rest of driver.

Please re-read what I said -- you broke error handling and potentially
resume. Previously, the firmware was available without a sleeping call
to user space to get it. Now, it is not. You cannot sleep in
typhoon_tx_timeout(), and trying to get a firmware image in resume is
going to be a problem if your file system is NFS mounted over the NIC
you're trying to resume.

http://marc.info/?l=linux-kernel&m=121608383506190&w=2
http://marc.info/?l=linux-kernel&m=121608255704704&w=2


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html