netdev - Re: [PATCH 2/7] drivers/net/ehea/ehea_main.c: Release mutex in error handling code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200807291014.55388.ossthema@de.ibm.com>
Date:	Tue, 29 Jul 2008 10:14:55 +0200
From:	Jan-Bernd Themann <ossthema@...ibm.com>
To:	Julia Lawall <julia@...u.dk>
Cc:	jgarzik@...ox.com, raisch@...ibm.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/7] drivers/net/ehea/ehea_main.c: Release mutex in error handling code

On Monday 21 July 2008 09:57, Julia Lawall wrote:
> From: Julia Lawall <julia@...u.dk>
> 
> The mutex is released on a successful return, so it would seem that it
> should be released on an error return as well.
> 
> The semantic patch finds this problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
> 
> // <smpl>
> @@
> expression l;
> @@
> 
> mutex_lock(l);
> ... when != mutex_unlock(l)
>     when any
>     when strict
> (
> if (...) { ... when != mutex_unlock(l)
> +   mutex_unlock(l);
>     return ...;
> }
> |
> mutex_unlock(l);
> )
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>
> 
> ---
> diff -u -p a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
> --- a/drivers/net/ehea/ehea_main.c
> +++ b/drivers/net/ehea/ehea_main.c
> @@ -2937,9 +2937,9 @@ static void ehea_rereg_mrs(struct work_s
>  				}
>  			}
>  		}
> -       mutex_unlock(&dlpar_mem_lock);
> -       ehea_info("re-initializing driver complete");
> +	ehea_info("re-initializing driver complete");
>  out:
> +	mutex_unlock(&dlpar_mem_lock);
>  	return;
>  }
> 
> --

The patch looks good. 

Acked-by: Jan-Bernd Themann <themann@...ibm.com>

Thanks,
Jan-Bernd
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html