netdev - Re: [patch nacked? 2/4] 3c59x: fix PCI resource management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 31 Jul 2008 00:10:40 +0200
From:	Steffen Klassert <klassert@...hematik.tu-chemnitz.de>
To:	akpm@...ux-foundation.org
Cc:	jeff@...zik.org, netdev@...r.kernel.org, sshtylyov@...mvista.com,
	jgarzik@...ox.com
Subject: Re: [patch nacked? 2/4] 3c59x: fix PCI resource management

On Wed, Jul 30, 2008 at 12:40:47PM -0700, akpm@...ux-foundation.org wrote:
> From: Sergei Shtylyov <sshtylyov@...mvista.com>
> 
> The driver wrongly claimed I/O ports at an address returned by pci_iomap()
> -- even if it was passed an MMIO address.  Fix this by claiming/releasing
> all PCI resources in the PCI driver probe/remove handlers instead and get
> rid of the must_free_region flag weirdness (why would Cardbus claim
> anything for us?).
> 
> Also, the remove handler was trying to talk to the chip after having
> disabled its address decoders (at least on x86) -- fix this and get rid of
> useless VORTEX_PCI() calls.
> 
> While at it, fix some cases of the overly indented code...
> 

The compile error of that patch should be fixed by git commit
0da0ead90122578ef6e4afba9ba4bcd3455fd8e8 at least.

I'll take this one and look at it.

Steffen
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html