netdev - Re: [patch 12/12] Configure out ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adatze7x7wv.fsf@cisco.com>
Date:	Wed, 30 Jul 2008 16:35:12 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	shemminger@...tta.com, jeff@...zik.org, netdev@...r.kernel.org,
	davem@...emloft.net, mpm@...enic.com
Subject: Re: [patch 12/12] Configure out ethtool support

 > I don't really trust allnoconfig as a way of determining size changes. 
 > It can easily be the case that kernel A's allnoconfig happens to pull
 > in more stuff than kernel B's allnoconfig.
 > 
 > So I do think that one should dive into the details and verify that
 > particular size changes really are due to unavoidable code bloat,
 > rather than being due to some unfortunate Kconfig change.

The following is rather squishy, but... when I've looked at the growth
of various bits of the kernel over time, a good bit of the growth comes
from changes like "add handling for undeniably useful feature X" or "add
handling of error condition Y."  And it's 50 bytes here, 100 bytes
there, and all the changes make sense and are too small to make
configurable.  So being able to get 6K all at once from ethtool is
actually pretty good, although probably not quite good enough to merge.

I really don't know what the right answer is to all of this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html