netdev - Re: [PATCH] IPv6: datagram_send_ctl() should exit immediately when an error occured

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080729.235806.263807229.davem@davemloft.net>
Date:	Tue, 29 Jul 2008 23:58:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	miaox@...fujitsu.com
Cc:	netdev@...r.kernel.org, pekkas@...core.fi, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH] IPv6: datagram_send_ctl() should exit immediately when
 an error occured

From: Miao Xie <miaox@...fujitsu.com>
Date: Wed, 30 Jul 2008 09:30:43 +0800

> When an error occured, datagram_send_ctl() should exit immediately rather than
> continue to run the for loop. Otherwise, the variable err might be changed and
> the error might be hidden.
> 
> Fix this bug by using "goto" instead of "break".
> 
> Signed-off-by: Miao Xie <miaox@...fujitsu.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html