netdev - Re: using software TSO on non-TSO capable netdevices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080731023652.GA23814@xi.wantstofly.org>
Date:	Thu, 31 Jul 2008 04:36:52 +0200
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, akarkare@...vell.com,
	nico@....org
Subject: Re: using software TSO on non-TSO capable netdevices

On Thu, Jul 31, 2008 at 10:29:24AM +0800, Herbert Xu wrote:

> > Index: linux-2.6.27-rc1/net/ipv4/tcp_output.c
> > ===================================================================
> > --- linux-2.6.27-rc1.orig/net/ipv4/tcp_output.c
> > +++ linux-2.6.27-rc1/net/ipv4/tcp_output.c
> > @@ -1544,7 +1544,7 @@ static int tcp_write_xmit(struct sock *s
> >                        break;
> > 
> >                if (tso_segs == 1) {
> > -                       if (unlikely(!tcp_nagle_test(tp, skb, mss_now,
> > +                       if (unlikely(!tcp_nagle_test(tp, skb, 5 * mss_now,
> >                                                     (tcp_skb_is_last(sk, skb) ?
> >                                                      nonagle : TCP_NAGLE_PUSH))))
> >                                break;
> 
> What's the size of your application's write calls?

The maximum that splice will allow -- PIPE_BUFFERS * PAGE_SIZE.

I.e. the writes should be large enough.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html