netdev - Re: [PATCH] net-sched: add packet length pointer parameter for qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080731174919.157875i4bpxod3wg@hayate.ip6>
Date:	Thu, 31 Jul 2008 17:49:19 +0300
From:	"Jussi Kivilinna" <jussi.kivilinna@...et.fi>
To:	"Jarek Poplawski" <jarkao2@...il.com>
Cc:	"David Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] net-sched: add packet length pointer parameter for
	qdisc_enqueue

Quoting "Jarek Poplawski" <jarkao2@...il.com>:

> On Thu, Jul 31, 2008 at 12:04:57PM +0300, Jussi Kivilinna wrote:
>> Quoting "Jarek Poplawski" <jarkao2@...il.com>:
>>
>>> On 30-07-2008 20:55, Jussi Kivilinna wrote:
>>>> Pass packet length to caller through pointer so that length is
>>>> available to caller even if inner qdisc frees skb.
> ...
>>> As I've written before, IMHO using an skb after enqueuing should be
>>> avoided unless we refcounted it or the returned code is clear enough,
>>> so the idea of this patch could be right to me. But, I guess, you are
>>> changing here the way it's done: the size is calculated before the
>>> current enqueing instead of after the last one.
>>
>> Doh, you're right. qdisc->enqueue should pass packet length too.
>>
>>>
>>> BTW, since I don't really get this "stab" idea enough, I wonder how
>>> it is expected to be used: with a top qdisc, a leaf one or some
>>> summing?
>>>
>>
>> With top and/or leaf qdisc, inner stab overrides upper.
>
> Probably this could be called a bit ugly, but another way could be
> simply updating these .bstas.bytes in ->dequeue() with a difference
> between calculated and skb->len?
>

That would work, but HFSC uses packet length in enqueue for something  
else too:
	if (cl->qdisc->q.qlen == 1)
		set_active(cl, qdisc_pkt_len(skb));

Could this bit be moved to dequeue?

  - Jussi


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html