| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 31 Jul 2008 23:28:09 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: Simon Horman <horms@...ge.net.au> Cc: jeff@...zik.org, netdev@...r.kernel.org Subject: Re: [patch for 2.6.27? 2/2] drivers/net/netxen/netxen_nic_hw.c: fix printk warnings On Fri, 1 Aug 2008 16:19:53 +1000 Simon Horman <horms@...ge.net.au> wrote: > On Wed, Jul 30, 2008 at 12:50:12PM -0700, akpm@...ux-foundation.org wrote: > > From: Andrew Morton <akpm@...ux-foundation.org> > > > > drivers/net/netxen/netxen_nic_hw.c: In function 'netxen_nic_pci_mem_read_direct': > > drivers/net/netxen/netxen_nic_hw.c:1414: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'u64' > > drivers/net/netxen/netxen_nic_hw.c: In function 'netxen_nic_pci_mem_write_direct': > > drivers/net/netxen/netxen_nic_hw.c:1487: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'u64' > > > > You don't know what type was used for u64 hence they cannot be printed without > > casting. > > Good grief, that is a sledgehammer to crack an egg. > Pity it is the only tool available :-( The sad thing is that if/when we get around to converting all 64-bit architectures to `long long', we then get to delete all these casts. Oh well, at least they're easy to grep for. I wonder who was the first 64-bit bright spark who decided to use `long'. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists