netdev - Re: [PATCH] inet6: Fix paramater issue of inet6_csk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080801.021825.51896743.davem@davemloft.net>
Date:	Fri, 01 Aug 2008 02:18:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	yjwei@...fujitsu.com, netdev@...r.kernel.org
Subject: Re: [PATCH] inet6: Fix paramater issue of inet6_csk_xmit

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Fri, 01 Aug 2008 17:11:01 +0800

> Wei Yongjun <yjwei@...fujitsu.com> wrote:
> >
> > inet6_csk_xmit() just be used by tcp and dccp:
> > 1042 net/dccp/ipv6.c      .queue_xmit       = inet6_csk_xmit
> > 1853 net/ipv6/tcp_ipv6.c     .queue_xmit       = inet6_csk_xmit,
> > 
> > And used always with ipfragok = 0.
> > 139 net/dccp/output.c         err = icsk->icsk_af_ops->queue_xmit(skb, 0);
> > 626 net/ipv4/tcp_output.c     err = icsk->icsk_af_ops->queue_xmit(skb, 0);
> > 
> > I can not find any place used inet6_csk_xmit() with ipfragok = 1.
> > 
> > So I think it is safe to apply this patch. Or maybe this paramater is 
> > useless.
> 
> No we should get rid of the ipfragok argument if noone uses it.

SCTP calls ip_queue_xmit() and ip6_xmit() directly with it's ipfragok
argument, so it is used for these functions.

As a result ->icsk_af_ops->queue_xmit() needs to have arguments
at least matching those function's prototypes.





--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html