netdev - Re: [PATCH] inet6: Fix paramater issue of inet6_csk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080801115041.GA19124@gondor.apana.org.au>
Date:	Fri, 1 Aug 2008 19:50:41 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	David Miller <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>
Cc:	yjwei@...fujitsu.com, netdev@...r.kernel.org
Subject: Re: [PATCH] inet6: Fix paramater issue of inet6_csk_xmit

On Fri, Aug 01, 2008 at 05:25:48PM +0800, Herbert Xu wrote:
>
> Hmm, so SCTP is the only reason why ipfragok exists and yet it
> doesn't even use icsk_af_ops->queue_xmit.  So unless SCTP has
> plans to use icsk_af_ops, perhaps we could provide it a copy of
> ip_queue_xmit/ip6_xmit that has the ipfragok argument and then
> put a wrapper around them without the argument for icsk_af_ops
> and everybody else.

I dug up this thread from the archives:

http://osdir.com/ml/network/2003-01/msg00065.html

SCTP is just a POS.

However, I think we can improve on what we have at the moment.
Really we only need to clear the DF bit on packets which are
above the PMTU on output.  There is no need to clear the DF for
packets which we don't need to fragment ourselves.

Yes, the RFC says we SHOULD do that, but it's braindead.  In any
case, this isn't allowed by IPv6 and it makes little sense for IPv4.
If we are doing PMTU then we want to get that error back in all
cases.

So we should be able to simply replace ipfragok with skb->local_df.
The only trouble is that SCTP doesn't seem to keep its PMTU setting
in the usual spot so we'll need to fix that before this can be done.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html