netdev - Re: [PATCHv2] ipv6: Fix ip6_xmit to send fragments if ipfragok is true

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080731.204719.266390212.davem@davemloft.net>
Date:	Thu, 31 Jul 2008 20:47:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	yjwei@...fujitsu.com, netdev@...r.kernel.org
Subject: Re: [PATCHv2] ipv6: Fix ip6_xmit to send fragments if ipfragok is
 true

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Thu, 31 Jul 2008 18:41:50 +0800

> On Thu, Jul 31, 2008 at 05:55:29PM +0800, Wei Yongjun wrote:
> > SCTP used ip6_xmit() to send fragments after received ICMP packet too
> > big message. But while send packet used ip6_xmit, the skb->local_df is
> > not initialized. So when skb if enter ip6_fragment(), the following
> > code will discard the skb.
> > 
> > ip6_fragment(...)
> > {
> >    if (!skb->local_df) {
> >        ...
> >        return -EMSGSIZE;
> >    }
> >    ...
> > }
> > 
> > SCTP do the following step:
> > 1. send packet ip6_xmit(skb, ipfragok=0)
> > 2. received ICMP packet too big message
> > 3. if PMTUD_ENABLE: ip6_xmit(skb, ipfragok=1)
> > 
> > This patch fixed the problem by set local_df if ipfragok is true.
> > 
> > Signed-off-by: Wei Yongjun <yjwei@...fujitsu.com>
> 
> Acked-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied, and I'll queue this up for -stable.

Thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html