netdev - Re: [PATCH 03/10] fs-enet: remove code associated with !CONFIG_PPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20080801185714.GA26062@ld0162-tx32.am.freescale.net>
Date:	Fri, 1 Aug 2008 13:57:14 -0500
From:	Scott Wood <scottwood@...escale.com>
To:	Kumar Gala <galak@...nel.crashing.org>
Cc:	linuxppc-dev@...abs.org, netdev@...r.kernel.org, jgarzik@...ox.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/10] fs-enet: remove code associated with !CONFIG_PPC_MERGE

On Fri, Aug 01, 2008 at 11:44:13AM -0500, Kumar Gala wrote:
> diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c
> index 9a51ec8..e54d003 100644
> --- a/drivers/net/fs_enet/fs_enet-main.c
> +++ b/drivers/net/fs_enet/fs_enet-main.c
> @@ -669,7 +669,6 @@ static int fs_request_irq(struct net_device *dev, int irq, const char *name,
>  {
>  	struct fs_enet_private *fep = netdev_priv(dev);
>  
> -	(*fep->ops->pre_request_irq)(dev, irq);
>  	return request_irq(irq, irqf, IRQF_SHARED, name, dev);
>  }

This makes "fep" an unused variable.  Eliminate this function entirely,
and call request_irq directly from the caller.

>  
> @@ -678,7 +677,6 @@ static void fs_free_irq(struct net_device *dev, int irq)
>  	struct fs_enet_private *fep = netdev_priv(dev);
>  
>  	free_irq(irq, dev);
> -	(*fep->ops->post_free_irq)(dev, irq);
>  }

Likewise.

-Scott
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html