netdev - Re: [PATCH] MD5: Fix MD5 signatures on certain ACK packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080731.205039.95463450.davem@davemloft.net>
Date:	Thu, 31 Jul 2008 20:50:39 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	agl@...erialviolet.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] MD5: Fix MD5 signatures on certain ACK packets

From: "Adam Langley" <agl@...erialviolet.org>
Date: Thu, 31 Jul 2008 19:56:31 -0700

> I noticed, looking at tcpdumps, that timewait ACKs were getting sent with an
> incorrect MD5 signature when signatures were enabled.
> 
> I broke this in 49a72dfb8814c2d65bd9f8c9c6daf6395a1ec58d. I didn't take into
> account that the skb passed to tcp_*_send_ack was the inbound packet, thus the
> source and dest addresses need to be swapped when calculating the MD5
> pseudoheader.
> 
> Signed-off-by: Adam Langley <agl@...erialviolet.org>

Applied.

But please provide commit header line text when referencing SHA IDs.
Here is the final fixed up commit message I used when applying this.

    tcp: MD5: Fix MD5 signatures on certain ACK packets
    
    I noticed, looking at tcpdumps, that timewait ACKs were getting sent
    with an incorrect MD5 signature when signatures were enabled.
    
    I broke this in 49a72dfb8814c2d65bd9f8c9c6daf6395a1ec58d ("tcp: Fix
    MD5 signatures for non-linear skbs"). I didn't take into account that
    the skb passed to tcp_*_send_ack was the inbound packet, thus the
    source and dest addresses need to be swapped when calculating the MD5
    pseudoheader.
    
    Signed-off-by: Adam Langley <agl@...erialviolet.org>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html