netdev - Re: [PATCH] sh_eth Add SH7619 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080802073021.GA30041@verge.net.au>
Date:	Sat, 2 Aug 2008 17:30:22 +1000
From:	Simon Horman <horms@...ge.net.au>
To:	Yoshinori Sato <ysato@...rs.sourceforge.jp>
Cc:	Nobuhiro Iwamatsu <iwamatsu@...auri.org>,
	Jeff Garzik <jeff@...zik.org>,
	Nobuhiro Iwamatsu <iwamatsu.nobuhiro@...esas.com>,
	netdev@...r.kernel.org, linux-sh@...r.kernel.org
Subject: Re: [PATCH] sh_eth Add SH7619 support

On Fri, Aug 01, 2008 at 11:32:28AM -0400, Yoshinori Sato wrote:
> At Fri, 1 Aug 2008 12:48:27 +0900,
> Nobuhiro Iwamatsu wrote:
> > 
> > Hi, Sato-san.
> > 
> > 2008/8/1 Yoshinori Sato <ysato@...rs.sourceforge.jp>:
> > > SH7619 have same SH7710 ethernet controler.
> > > Add support for sh_eth driver.
> > >
> > > Signed-off-by: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> > >
> > 
> > <snip>
> > 
> > >
> > > diff --git a/drivers/net/sh_eth.h b/drivers/net/sh_eth.h
> > > index 45ad1b0..ca3cc5f 100644
> > > --- a/drivers/net/sh_eth.h
> > > +++ b/drivers/net/sh_eth.h
> > > @@ -143,10 +143,11 @@
> > >
> > 
> > <snip>
> > 
> > > +
> > > +/* CPU endian from/to EDMAC endian */
> > > +#if !defined(CONFIG_CPU_SUBTYPE_SH7619)
> > > +#define cpu_to_edmac(x) cpu_to_le32(x)
> > > +#define edmac_to_cpu(x) le32_to_cpu(x)
> > > +#else
> > > +#define cpu_to_edmac(x) cpu_to_be32(x)
> > > +#define edmac_to_cpu(x) be32_to_cpu(x)
> > > +#endif
> > > +
> > >  #endif
> > I think that this depends on an endian not CPU dependence.
> 
> I agree.
> But I'm no idea.
> Are you have good idea?

Iwamatsu-san,

what is the difference between CONFIG_CPU_LITTLE_ENDIAN and
__LITTLE_ENDIAN__ as used in drivers/net/sh_eth.h ?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html