netdev - RE: [BUG] NULL pointer dereference in skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <EA929A9653AAE14F841771FB1DE5A1365F1FBE8B45@rrsmsx501.amr.corp.intel.com>
Date:	Sat, 2 Aug 2008 15:46:13 -0600
From:	"Tantilov, Emil S" <emil.s.tantilov@...el.com>
To:	"Tantilov, Emil S" <emil.s.tantilov@...el.com>,
	David Miller <davem@...emloft.net>,
	"jarkao2@...il.com" <jarkao2@...il.com>
CC:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [BUG] NULL pointer dereference in skb_dequeue

Tantilov, Emil S wrote:
> Still no luck.
>
> I was able to reset the interfaces and change the MTU multiple times
> until eventually the system froze. No trace.
>
> Emil
>
> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Saturday, August 02, 2008 12:23 PM
> To: jarkao2@...il.com
> Cc: Tantilov, Emil S; Kirsher, Jeffrey T; netdev@...r.kernel.org
> Subject: Re: [BUG] NULL pointer dereference in skb_dequeue
>
> From: David Miller <davem@...emloft.net>
> Date: Sat, 02 Aug 2008 12:18:15 -0700 (PDT)
>
>> See my other emails, it isn't even necessary anyways.
>
> Sorry, because some idiot took part of the conversation private
> my follow-on fixup patch didn't make it to the list, here it is.
>
> It goes on top of the original patch I sent out:
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 69320a5..da7acac 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -1796,7 +1796,7 @@ gso:
>         skb->tc_verd = SET_TC_AT(skb->tc_verd,AT_EGRESS);
>  #endif
>         if (q->enqueue) {
> -               spinlock_t *root_lock = qdisc_root_lock(q);
> +               spinlock_t *root_lock = qdisc_lock(q);
>
>                 spin_lock(root_lock);
>
> @@ -1995,7 +1995,7 @@ static void net_tx_action(struct softirq_action
>                         *h) smp_mb__before_clear_bit();
>                         clear_bit(__QDISC_STATE_SCHED, &q->state);
>
> -                       root_lock = qdisc_root_lock(q);
> +                       root_lock = qdisc_lock(q);
>                         if (spin_trylock(root_lock)) {
>                                 qdisc_run(q);
>                                 spin_unlock(root_lock);

Disregard my previous emails. This patch seems to fix the panic. I will leave a longer term stress test running to make sure it'stable.

Thanks,
Emil
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html