netdev - Re: [PATCH 2/2] net: fix missing pneigh entries in the neighbor seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080803.011116.145945086.davem@davemloft.net>
Date:	Sun, 03 Aug 2008 01:11:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	clarson@...sta.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] net: fix missing pneigh entries in the neighbor
 seq_file code

From: Chris Larson <clarson@...sta.com>
Date: Fri,  1 Aug 2008 14:49:49 -0700

> When pneigh entries exist, but the user's read buffer isn't sufficient to
> hold them all, one of the pneigh entries will be missing from the results.
> 
> In neigh_get_idx_any, the number of elements which neigh_get_idx
> encountered is not correctly subtracted from the position number before
> the call to pneigh_get_idx.  neigh_get_idx reduces the position by 1 for
> each call to neigh_get_next, but it does not reduce it by one for the
> first element (neigh_get_first). The patch alters the neigh_get_idx and
> pneigh_get_idx functions to subtract one from pos, for the first element,
> when pos is non-zero.
> 
> Signed-off-by: Chris Larson <clarson@...sta.com>

This looks good too, applied.

Thanks Chris.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html