netdev - Re: [PATCH] inet6: Fix paramater issue of inet6_csk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080802.235640.250921883.davem@davemloft.net>
Date:	Sat, 02 Aug 2008 23:56:40 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vladislav.yasevich@...com
Cc:	herbert@...dor.apana.org.au, kuznet@....inr.ac.ru,
	yjwei@...fujitsu.com, netdev@...r.kernel.org
Subject: Re: [PATCH] inet6: Fix paramater issue of inet6_csk_xmit

From: Vlad Yasevich <vladislav.yasevich@...com>
Date: Sat, 02 Aug 2008 19:26:29 -0400

> Herbert Xu wrote:
> > On Fri, Aug 01, 2008 at 10:50:17AM -0400, Vlad Yasevich wrote:
> >>> +	inet->pmtudisc = transport->param_flags & SPP_PMTUD_ENABLE ?
> >>> +			 IP_PMTUDISC_DO : IP_PMTUDISC_DONT;
> >> If you insist on doing this, you need to save the old value and restore
> >> it after ip_queue_xmit(). 
> >>
> >> The reason is that PMTU discovery change on a specific transport or
> >> association should not affect the socket, since there could be multiple
> >> associations on a given socket.  Each association has it's own control.
> > 
> > Yes but they'll all pass through here so it'll get set to the
> > appropriate value.
> > 
> > Cheers,
> 
> OK, I see what you mean.  Let me run some tests with this patch.  I doesn't
> look like it will cause any issues, but I'd like to verify.

Like Herbert said, thanks for doing this testing.

Let me know how it goes so I can apply the patch if everything
is OK.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html