netdev - Re: [PATCH take 2] net_sched: Add qdisc __NET_XMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080803.234200.193697269.davem@davemloft.net>
Date:	Sun, 03 Aug 2008 23:42:00 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jarkao2@...il.com
Cc:	kaber@...sh.net, jussi.kivilinna@...et.fi, netdev@...r.kernel.org
Subject: Re: [PATCH take 2] net_sched: Add qdisc __NET_XMIT_BYPASS flag

From: Jarek Poplawski <jarkao2@...il.com>
Date: Mon, 4 Aug 2008 06:28:13 +0000

> These 2 patches aren't supposed to fix these problems:
> 
> - the __NET_XMIT_STOLEN patch fixes a problem when a qdiscs passed
>   upwards NET_XMIT_SUCCESS when eg. an skb was stolen by an action,
>   to prevent treating this as dropped; then the upper qdiscs couldn't
>   tell it's not the full NET_XMIT_SUCCESS and counted it as queued,
>   which was wrong. (BTW, I especially tried to do it with minimal
>   changes in htb_enqueue() to let you apply your htb patch without
>   much editing.)
> 
> - the __NET_XMIT_BYPASS actually doesn't fix any serious problem, but
>   lets to remove the mapping from dev_queue_xmit(), and BTW it passes
>   better information to upper qdiscs too.

I understand.

But be aware that all of these things are related :-)

> Subject: net_sched: Add qdisc __NET_XMIT_BYPASS flag
> 
> Patrick McHardy <kaber@...sh.net> noticed that it would be nice to
> handle NET_XMIT_BYPASS by NET_XMIT_SUCCESS with an internal qdisc flag
> __NET_XMIT_BYPASS and to remove the mapping from dev_queue_xmit().
> 
> David Miller <davem@...emloft.net> spotted a serious bug in the first
> version of this patch.
> 
> 
> Signed-off-by: Jarek Poplawski <jarkao2@...il.com>
 ...
> @@ -331,14 +331,14 @@ static inline unsigned int qdisc_pkt_len(struct sk_buff *skb)
>  	return qdisc_skb_cb(skb)->pkt_len;
>  }
>  
> -#ifdef CONFIG_NET_CLS_ACT
> -/* additional qdisc xmit flags */
> +/* additional qdisc xmit flags (NET_XMIT_MASK in linux/netdevice.h) */
>  enum net_xmit_qdisc_t {
> -	__NET_XMIT_STOLEN = NET_XMIT_MASK + 1,
> +	__NET_XMIT_STOLEN = 0x0001FFFF,
> +	__NET_XMIT_BYPASS = 0x0002FFFF,
>  };
>  

Please, respin both patches, so that the "NET_XMIT_MASK + 1"
construct doesn't ever exist in the tree.

Thanks again.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html