netdev - Re: bridge: Eliminate unnecessary forward delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080804173220.GA14093@gondor.apana.org.au>
Date:	Tue, 5 Aug 2008 01:32:20 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: bridge: Eliminate unnecessary forward delay

On Mon, Aug 04, 2008 at 10:27:03AM -0700, Stephen Hemminger wrote:
> 
> How about this, it is simpler just to do the state change.

Sure, that should work as well.

> --- a/net/bridge/br_stp.c	2008-08-04 10:20:21.000000000 -0700
> +++ b/net/bridge/br_stp.c	2008-08-04 10:26:04.000000000 -0700
> @@ -368,14 +368,26 @@ static void br_make_blocking(struct net_
>  /* called under bridge lock */
>  static void br_make_forwarding(struct net_bridge_port *p)
>  {
> -	if (p->state == BR_STATE_BLOCKING) {
> -		if (p->br->stp_enabled == BR_KERNEL_STP)
> -			p->state = BR_STATE_LISTENING;
> -		else
> -			p->state = BR_STATE_LEARNING;
> +	struct net_bridge *br = p->br;
>  
> -		br_log_state(p);
> -		mod_timer(&p->forward_delay_timer, jiffies + p->br->forward_delay);	}
> +	if (p->state != BR_STATE_BLOCKING)
> +		return;
> +
> +	if (br->forward_delay == 0) {
> +		p->state = BR_STATE_FORWARDING;
> +		if (br_is_designated_for_some_port(br))
> +			br_topology_change_detection(br);

Provided that you make br_is_designated_for_some_port available
first :)

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html