netdev - Re: [PATCH] net_sched: Add qdisc __NET_XMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080803.182524.240976246.davem@davemloft.net>
Date:	Sun, 03 Aug 2008 18:25:24 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jarkao2@...il.com
Cc:	kaber@...sh.net, jussi.kivilinna@...et.fi, netdev@...r.kernel.org
Subject: Re: [PATCH] net_sched: Add qdisc __NET_XMIT_BYPASS flag

From: Jarek Poplawski <jarkao2@...il.com>
Date: Fri, 1 Aug 2008 10:19:29 +0000

> @@ -331,14 +331,14 @@ static inline unsigned int qdisc_pkt_len(struct sk_buff *skb)
>  	return qdisc_skb_cb(skb)->pkt_len;
>  }
>  
> -#ifdef CONFIG_NET_CLS_ACT
>  /* additional qdisc xmit flags */
>  enum net_xmit_qdisc_t {
> -	__NET_XMIT_STOLEN = NET_XMIT_MASK + 1,
> +	__NET_XMIT_STOLEN = NET_XMIT_MASK + 0x1,
> +	__NET_XMIT_BYPASS = NET_XMIT_MASK + 0x2,
>  };
>  

NET_XMIT_MASK + 0x2 is (0xffff + 2) which is 0x10001 and this is very
much not what you intended.

Please just explicitly spell out the bit mask values instead of trying
to create some false relationship with the mask and these values.

Next, these patches doesn't fix the while problem, in that htb and
friends are still corrupting the enqueue return value so that TCP is
going to do the wrong thing still.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html