netdev - Re: [PATCH 2/2 respin] net_sched: Add qdisc __NET_XMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080804.233122.132106854.davem@davemloft.net>
Date:	Mon, 04 Aug 2008 23:31:22 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jarkao2@...il.com
Cc:	kaber@...sh.net, jussi.kivilinna@...et.fi, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2 respin] net_sched: Add qdisc __NET_XMIT_BYPASS flag

From: Jarek Poplawski <jarkao2@...il.com>
Date: Tue, 5 Aug 2008 06:34:23 +0000

> NAK! You're not allowed to remove such a great comment!
> 
> BTW, I hope you've checked this enough, becouse I've some doubts
> here: this NET_XMIT_BYPASS looks wrong here but maybe it was meant
> to be some NET_RX_ code, like NET_RX_CN_HIGH?

I think it was trying to handle the cases where the
input packet called dev_queue_xmit() and that return
value funnelled back into dst_input().

But that couldn't happen, and even if it could dev_queue_xmit()
always "fixed up" NET_XMIT_BYPASS so that callers never saw it.

Really, this code was totally useless as far as I can tell.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html