netdev - Re: [PATCH 2/2] Interfamily IPSec BEET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200808051013.19873.joakim.koskela@hiit.fi>
Date:	Tue, 5 Aug 2008 10:13:19 +0300
From:	Joakim Koskela <joakim.koskela@...t.fi>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	netdev@...r.kernel.org, yoshfuji@...e.ad.jp
Subject: Re: [PATCH 2/2] Interfamily IPSec BEET

On Monday 04 August 2008 19:20:46 Herbert Xu wrote:
> > diff --git a/net/ipv6/esp6.c b/net/ipv6/esp6.c
> > index c6bb4c6..f09fcb9 100644
> > --- a/net/ipv6/esp6.c
> > +++ b/net/ipv6/esp6.c
> > @@ -521,6 +521,10 @@ static int esp6_init_state(struct xfrm_state *x)
> >  			      crypto_aead_ivsize(aead);
> >  	switch (x->props.mode) {
> >  	case XFRM_MODE_BEET:
> > +		x->props.header_len += IPV4_BEET_PHMAXLEN;
> > +		if (x->sel.family == AF_INET)
> > +			x->props.header_len += (sizeof(struct ipv6hdr) - sizeof(struct
> > iphdr));
>
> This is still going to break with the new any family (i.e., v4
> or v6) SA.  So perhaps that should be x->sel.family != AF_INET6.
>
> Cheers,

Hi, and thanks for checking this out. Didn't think about the any family, 
thanks for catching that. I'll resubmit this part.

br, j
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html