netdev - Re: [PATCH take 2] net_sched: Add qdisc __NET_XMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080805154350.27523juch31xgjcw@hayate.ip6>
Date:	Tue, 05 Aug 2008 15:43:50 +0300
From:	"Jussi Kivilinna" <jussi.kivilinna@...et.fi>
To:	"Jarek Poplawski" <jarkao2@...il.com>
Cc:	"David Miller" <davem@...emloft.net>, kaber@...sh.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH take 2] net_sched: Add qdisc __NET_XMIT_BYPASS flag

Quoting "Jarek Poplawski" <jarkao2@...il.com>:

> On Mon, Aug 04, 2008 at 09:35:35PM +0300, Jussi Kivilinna wrote:
>> Quoting "Jarek Poplawski" <jarkao2@...il.com>:
>>
>> This seems to also make sure that when returning 'full'
>> NET_XMIT_SUCCESS, skb pointer is safe(r?) to use now.
>
> I guess so... At least theoretically - I was mainly afraid of
> redirecting, which isn't fully implemented yet. On the other hand,
> outwards of qdiscs there is still no difference.
>

How about making skb shared before passing into qdisc tree?
That would make skb usage safe after qdisc enqueues.

---

diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
index c5bb130..9cf06fc 100644
--- a/include/net/sch_generic.h
+++ b/include/net/sch_generic.h
@@ -352,10 +352,16 @@ static inline int qdisc_enqueue(struct sk_buff  
*skb, struct Qdisc *sch)
         return sch->enqueue(skb, sch);
  }

-static inline int qdisc_enqueue_root(struct sk_buff *skb, struct Qdisc *sch)
+static inline int qdisc_enqueue_root(struct sk_buff *__skb, struct  
Qdisc *sch)
  {
+       struct sk_buff *skb = skb_get(__skb);
+       int ret;
+
         qdisc_skb_cb(skb)->pkt_len = skb->len;
-       return qdisc_enqueue(skb, sch);
+       ret = qdisc_enqueue(skb, sch);
+       kfree_skb(skb);
+
+       return ret;
  }

  static inline int __qdisc_enqueue_tail(struct sk_buff *skb, struct  
Qdisc *sch,

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html