[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <489926B2.7030800@cn.fujitsu.com>
Date: Wed, 06 Aug 2008 12:21:06 +0800
From: Wang Chen <wangchen@...fujitsu.com>
To: Divy Le Ray <divy@...lsio.com>
CC: David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH]&[Question] netdevice: Use netdev_priv()
Divy Le Ray said the following on 2008-8-6 1:51:
> On Tuesday 05 August 2008 03:04:33 am David Miller wrote:
>> From: Wang Chen <wangchen@...fujitsu.com>
>> Date: Tue, 05 Aug 2008 17:55:27 +0800
>>
>>> init_one() of cxgb2 makes several net_device to share one private data.
>>> For this purpose, direct reference is necessary.
>> It should use netdev->ml_priv which is created for this purpose.
>>
>> Every direct netdev->priv usage is a bug.
>
> cxgb3 was fixed in this regard, cxgb2 needs the same treatment ...
>
Thanks Dave and Divy.
I am making the big patch for fixing all direct reference of netdev->priv.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists