netdev - Re: few more fixes for iproute2/m

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1218017085.4755.23.camel@localhost>
Date:	Wed, 06 Aug 2008 06:04:45 -0400
From:	jamal <hadi@...erus.ca>
To:	Denys Fedoryshchenko <denys@...p.net.lb>
Cc:	Stephen Hemminger <shemminger@...ux-foundation.org>,
	netdev@...r.kernel.org
Subject: Re: few more fixes for iproute2/m_ipt

Denys,

On Wed, 2008-06-08 at 00:42 +0300, Denys Fedoryshchenko wrote:
> Comments:
> 1)optind according iptables sources have to be set to 0. If it is set to 1, in 
> batch it will mess up things. Also in iptables sources i notice that ->tflags 
> and ->used need to be reset.

Indeed there seems to be an issue here, but:
Have you tried in your batch with a few "index"ed parameters to ipt with
your fix? I think it will break with your changes. Of course that does
not invalidate your concern. If you send me a two liner batch example
which breaks for you, I will test it.

> 2)Since target->t = fw_calloc(1, size); allocated memory in function build_st, 
> it have to be freed at the end, or in batch we will have memory leak. TODO: 
> Probably it must be freed in all "return -1" cases in parse_ipt after 
> build_st. About this i am not sure, up to Stephen.
> 
> 3)lname and new_name was malloc'ed, but not freed
> 
> Point 1 fix is critical, since without it m_ipt crashing iproute2 in batch 
> mode.

I think #2 and #3 are leggit. Send two patches - one for #1 when you
validate and the other for #2,#3 when you validate. BTW, for the
equivalent of the latter - if you feel brave - theres a lot more of that
type in the tc code.

cheers,
jamal

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html