netdev - Re: iproute2/m_ipt fix, opts was not set properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Aug 2008 14:02:00 +0300
From:	Denys Fedoryshchenko <denys@...p.net.lb>
To:	hadi@...erus.ca
Cc:	Stephen Hemminger <shemminger@...ux-foundation.org>,
	netdev@...r.kernel.org
Subject: Re: iproute2/m_ipt fix, opts was not set properly

On Wednesday 06 August 2008, jamal wrote:
> 1. change free_opts to be:
>
> static void free_opts(struct option **opts)
> {
>         if (*opts != original_opts) {
>                 free(*opts);
>                 *opts = original_opts;
>         }
> }
>
> 2. Change invocations of free_opts to be:
>
> free_opts(&opts);
>
> cheers,
> jamal
Does it work on my test batch?
Your way looks much more clean :-)
(I cannot test it properly, since i have modified iproute2 now)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html