netdev - Re: Realtek 8111C transmit timed out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080806190353.GB17174@electric-eye.fr.zoreil.com>
Date:	Wed, 6 Aug 2008 21:03:53 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	John P Poet <jppoet@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: Realtek 8111C transmit timed out

John P Poet <jppoet@...il.com> :
[...]
> Thank you for the response.  That DOES seem to fix the cold-boot issue.
> 
> Unfortunately, it does not fix the timeout problem.  I am still
> experiencing transmittion problems:

Does the patch below (on top of the current pile) make a difference ?

diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index c421bf6..348846f 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -874,12 +874,9 @@ static int rtl8169_set_speed_xmii(struct net_device *dev,
 
 	auto_nego |= ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM;
 
-	if ((tp->mac_version == RTL_GIGA_MAC_VER_12) ||
-	    (tp->mac_version == RTL_GIGA_MAC_VER_17)) {
-		/* Vendor specific (0x1f) and reserved (0x0e) MII registers. */
-		mdio_write(ioaddr, 0x1f, 0x0000);
-		mdio_write(ioaddr, 0x0e, 0x0000);
-	}
+	/* Vendor specific (0x1f) and reserved (0x0e) MII registers. */
+	mdio_write(ioaddr, 0x1f, 0x0000);
+	mdio_write(ioaddr, 0x0e, 0x0000);
 
 	tp->phy_auto_nego_reg = auto_nego;
 	tp->phy_1000_ctrl_reg = giga_ctrl;
-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html