netdev - Re: [PATCH] netxen_nic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080806021653.GA19137@verge.net.au>
Date:	Wed, 6 Aug 2008 12:16:53 +1000
From:	Simon Horman <horms@...ge.net.au>
To:	Alexander Beregalov <a.beregalov@...il.com>
Cc:	dhananjay@...xen.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netxen_nic_hw.c: fix warnings

On Wed, Aug 06, 2008 at 12:05:16AM +0400, Alexander Beregalov wrote:
> From: Alexander Beregalov <a.beregalov@...il.com>
> 
> netxen_nic_hw.c: fix warnings
> 
> drivers/net/netxen/netxen_nic_hw.c:1414: warning: format '%llx' expects	type 'long long unsigned int', but argument 3 has type 'u64'
> drivers/net/netxen/netxen_nic_hw.c:1487: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'u64'

This seems to be the agreed work-around for this.

Acked-by: Simon Horman <horms@...ge.net.au>

> Signed-off-by: Alexander Beregalov <a.beregalov@...il.com>
> ---
> 
>  drivers/net/netxen/netxen_nic_hw.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/netxen/netxen_nic_hw.c b/drivers/net/netxen/netxen_nic_hw.c
> index 96a3bc6..06a517b 100644
> --- a/drivers/net/netxen/netxen_nic_hw.c
> +++ b/drivers/net/netxen/netxen_nic_hw.c
> @@ -1411,7 +1411,8 @@ static int netxen_nic_pci_mem_read_direct(struct netxen_adapter *adapter,
>  		(netxen_nic_pci_is_same_window(adapter, off+size-1) == 0)) {
>  		write_unlock_irqrestore(&adapter->adapter_lock, flags);
>  		printk(KERN_ERR "%s out of bound pci memory access. "
> -			"offset is 0x%llx\n", netxen_nic_driver_name, off);
> +			"offset is 0x%llx\n", netxen_nic_driver_name,
> +			(unsigned long long)off);
>  		return -1;
>  	}
>  
> @@ -1484,7 +1485,8 @@ netxen_nic_pci_mem_write_direct(struct netxen_adapter *adapter, u64 off,
>  		(netxen_nic_pci_is_same_window(adapter, off+size-1) == 0)) {
>  		write_unlock_irqrestore(&adapter->adapter_lock, flags);
>  		printk(KERN_ERR "%s out of bound pci memory access. "
> -			"offset is 0x%llx\n", netxen_nic_driver_name, off);
> +			"offset is 0x%llx\n", netxen_nic_driver_name,
> +			(unsigned long long)off);
>  		return -1;
>  	}
>  
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html