netdev - Re: [PATCH][resend] xen-netfront: use netif_start_queue() on xennet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <489A923D.4080302@garzik.org>
Date:	Thu, 07 Aug 2008 02:12:13 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Eduardo Habkost <ehabkost@...hat.com>
CC:	David Miller <davem@...emloft.net>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, Jeremy Fitzhardinge <jeremy@...p.org>
Subject: Re: [PATCH][resend] xen-netfront: use netif_start_queue() on xennet_open()

Eduardo Habkost wrote:
> xen-netfront never called netif_start_queue() and was was waking the
> queue on xennet_open(), triggering the BUG_ON() on __netif_schedule().
> 
> Signed-off-by: Eduardo Habkost <ehabkost@...hat.com>
> ---
>  drivers/net/xen-netfront.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> index 902bbe7..c749bdb 100644
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -329,7 +329,7 @@ static int xennet_open(struct net_device *dev)
>  	}
>  	spin_unlock_bh(&np->rx_lock);
>  
> -	xennet_maybe_wake_tx(dev);
> +	netif_start_queue(dev);
>  

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html