netdev - Re: [PATCH] net: trap attempts to modify noop qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080806231516.659f82c5@extreme>
Date:	Wed, 6 Aug 2008 23:15:16 -0700
From:	Stephen Hemminger <stephen.hemminger@...tta.com>
To:	David Miller <davem@...emloft.net>
Cc:	kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH] net: trap attempts to modify noop qdisc

On Wed, 06 Aug 2008 23:11:59 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

> From: Stephen Hemminger <stephen.hemminger@...tta.com>
> Date: Wed, 6 Aug 2008 23:08:50 -0700
> 
> > Since noop qdisc is a singleton, it shouldn't end up with any other
> > qdisc's on it's list, and it shouldn't be deleted.
> > 
> > Dave, this should help you find the bug.
> 
> Thanks.

I think the root of your problem (bad pun) is that the new code
is assuming that changes to the root are done with parent handle of 0,
but the API is for the parent handle to be TC_H_ROOT (0xFFFFFFFFU).

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html