netdev - Re: [patch 06/12] hamradio: add missing sanity check to tty operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <489A94FA.3000808@garzik.org>
Date:	Thu, 07 Aug 2008 02:23:54 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	akpm@...ux-foundation.org
CC:	netdev@...r.kernel.org, eugeneteo@...nel.sg, alan@...hat.com,
	eteo@...hat.com
Subject: Re: [patch 06/12] hamradio: add missing sanity check to tty operation

akpm@...ux-foundation.org wrote:
> From: Eugene Teo <eugeneteo@...nel.sg>
> 
> Add missing sanity check to tty operation.
> 
> Acked-by: Alan Cox <alan@...hat.com>
> Signed-off-by: Eugene Teo <eteo@...hat.com>
> Cc: Jeff Garzik <jeff@...zik.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---
> 
>  drivers/net/hamradio/mkiss.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN drivers/net/hamradio/mkiss.c~hamradio-add-missing-sanity-check-to-tty-operation drivers/net/hamradio/mkiss.c
> --- a/drivers/net/hamradio/mkiss.c~hamradio-add-missing-sanity-check-to-tty-operation
> +++ a/drivers/net/hamradio/mkiss.c
> @@ -548,7 +548,7 @@ static int ax_xmit(struct sk_buff *skb, 
>  		}
>  
>  		printk(KERN_ERR "mkiss: %s: transmit timed out, %s?\n", dev->name,
> -		       (ax->tty->ops->chars_in_buffer(ax->tty) || ax->xleft) ?
> +		       (tty_chars_in_buffer(ax->tty) || ax->xleft) ?
>  		       "bad line quality" : "driver error");
>  
>  		ax->xleft = 0;

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html