netdev - Re: qdisc_enqueue, NET_XMIT_SUCCESS and kfree_skb (Was: Re: [PATCH take 2] net_sched: Add qdisc __NET_XMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080807144048.10175sn7i3u7qlmo@hayate.ip6>
Date:	Thu, 07 Aug 2008 14:40:48 +0300
From:	"Jussi Kivilinna" <jussi.kivilinna@...et.fi>
To:	"Jarek Poplawski" <jarkao2@...il.com>
Cc:	"David Miller" <davem@...emloft.net>, kaber@...sh.net,
	netdev@...r.kernel.org
Subject: Re: qdisc_enqueue, NET_XMIT_SUCCESS and kfree_skb (Was: Re: [PATCH
	take 2] net_sched: Add qdisc __NET_XMIT_BYPASS flag)

Quoting "Jarek Poplawski" <jarkao2@...il.com>:

>> PS. I noticed something fishy in HTB; HTB always returns NET_XMIT_DROP if
>> qdisc_enqueue doesn't return full NET_XMIT_SUCCESS, shouldn't it  
>> return return
>> value from qdisc_enqueue. Same in HTB requeue. That can't be right, right?
>>
>
> Yes, very good point, and quite hard to diagnose bug - happily solved
> already (but not fixed yet) by David Miller himself.

Ok, I assume that same case in sch_prio:requeue has been already spotted too.

>
> PS: it seems your mailer wrapped some lines of above patch.
>

Doh, time to find alternative for horde.

  - Jussi

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html