netdev - Re: [PATCH 1/3] Add (struct sock*) sk parameter for send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080806.202038.93643856.davem@davemloft.net>
Date:	Wed, 06 Aug 2008 20:20:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	guijianfeng@...fujitsu.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] Add (struct sock*) sk parameter for send_ack()

From: Gui Jianfeng <guijianfeng@...fujitsu.com>
Date: Tue, 05 Aug 2008 17:22:38 +0800

> Add (struct sock*) sk parameter for send_ack.
> 
> Signed-off-by: Gui Jianfeng <guijianfeng@...fujitsu.com>

This patch by itself breaks the build.

Don't submit patches this way.  Every patch applied should
still leave the tree building.

Also, since your OOPS and detailed description only exists
in the "0/3" email, it won't make it into the commit log
history where it belongs.

Considering all of this, I'd say you should fix this as
one big patch with a really nice commit log message.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html