[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 8 Aug 2008 10:58:58 +0200
From: Segher Boessenkool <segher@...nel.crashing.org>
To: benh@...nel.crashing.org
Cc: mcarlson@...adcom.com, linuxppc-dev list <linuxppc-dev@...abs.org>,
netdev <netdev@...r.kernel.org>, Nathan Lynch <ntl@...ox.com>,
Michael Chan <mchan@...adcom.com>
Subject: Re: Strange tg3 regression with UMP fw. link reporting
> I don't know yet for sure what happens, but a quick look at the commit
> seems to show that the driver synchronously spin-waits for up to 2.5ms
That's what the comment says, but the code says 2.5 _seconds_:
+ /* Wait for up to 2.5 milliseconds */
+ for (i = 0; i < 250000; i++) {
+ if (!(tr32(GRC_RX_CPU_EVENT) & GRC_RX_CPU_DRIVER_EVENT))
+ break;
+ udelay(10);
+ }
(not that milliseconds wouldn't be bad already...)
Segher
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists