netdev - Re: [NET]: remove unnecessary #include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Aug 2008 08:34:41 +0200
From:	Florian Fainelli <florian.fainelli@...ecomint.eu>
To:	Huang Weiyi <weiyi.huang@...il.com>
Cc:	romieu@...zoreil.com, jgarzik@...ox.com, jgarzik@...hat.com,
	netdev@...r.kernel.org
Subject: Re: [NET]: remove unnecessary #include

Hello Huang,

Le Monday 11 August 2008 06:56:44 Huang Weiyi, vous avez écrit :
> The drivers below do not use LINUX_VERSION_CODE nor KERNEL_VERSION.
>   drivers/net/acenic.c
>   drivers/net/bnx2x_link.c
>   drivers/net/bnx2x_main.c
>   drivers/net/cpmac.c
>   drivers/net/gianfar_sysfs.c
>   drivers/net/ipg.h
>   drivers/net/ppp_mppe.c
>   drivers/net/pppol2tp.c
>   drivers/net/r6040.c

The r6040 driver can have more include files removed. Patch attached below.
--
From: Florian Fainelli
Subject: [PATCH] r6040: remove unused includes

This patch removes all unused includes.

Signed-off-by: Florian Fainelli <florian.fainelli@...ecomint.eu>
--
diff --git a/drivers/net/r6040.c b/drivers/net/r6040.c
index 6531ff5..d453987 100644
--- a/drivers/net/r6040.c
+++ b/drivers/net/r6040.c
@@ -24,13 +24,9 @@
 
 #include <linux/kernel.h>
 #include <linux/module.h>
-#include <linux/version.h>
-#include <linux/moduleparam.h>
-#include <linux/string.h>
 #include <linux/timer.h>
 #include <linux/errno.h>
 #include <linux/ioport.h>
-#include <linux/slab.h>
 #include <linux/interrupt.h>
 #include <linux/pci.h>
 #include <linux/netdevice.h>
@@ -45,9 +41,6 @@
 #include <linux/bitops.h>
 #include <linux/io.h>
 #include <linux/irq.h>
-#include <linux/uaccess.h>
-
-#include <asm/processor.h>
 
 #define DRV_NAME	"r6040"
 #define DRV_VERSION	"0.18"
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html