netdev - Re: [PATCH] net, wd.c: fix undefined reference to `NS8390p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080811111116.GA6121@elte.hu>
Date:	Mon, 11 Aug 2008 13:11:17 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jeff Garzik <jgarzik@...ox.com>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] net, wd.c: fix undefined reference to `NS8390p_init'


* Jeff Garzik <jgarzik@...ox.com> wrote:

> Ingo Molnar wrote:
>> * Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
>>
>>> On Thu, 7 Aug 2008 09:20:07 +0200 (CEST)
>>> Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>>>
>>>> On Wed, 6 Aug 2008, Randy Dunlap wrote:
>>>>> One randconfig ends with:
>>>>>
>>>>> drivers/built-in.o: In function `wd_probe1':
>>>>> wd.c:(.init.text+0x6179): undefined reference to `NS8390p_init'
>>>>> make[1]: *** [.tmp_vmlinux1] Error 1
>>>> drivers/net/Makefile has:
>>>>
>>>> obj-$(CONFIG_WD80x3) += wd.o 8390.o
>>>>
>>>> So either wd_probe1() should call NS8390_init(), or obj-$(CONFIG_WD80x3)
>>>> should link with 8390p.o. Don't know which is the appropriate change
>>>> here (my gut feeling says the latter).
>>> Safest is the latter. The shared memory interface on the wd is full  
>>> speed 8 or 16bit (depending on card/jumpers) but I'm not clear about  
>>> the NIC. Most of the performance hit is on the packet transfer which  
>>> is private methods on this device so using 8390p won't make a big  
>>> difference on this board anyway.
>>
>> Alan, Jeff, i triggered this too with latest -git, please pick up the  
>> fix below if you dont have it already.
>>
>> 	Ingo
>>
>> ------------------>
>>> From c03cb1727bb4c5433436bfb0fab59fdcc00749c3 Mon Sep 17 00:00:00 2001
>> From: Ingo Molnar <mingo@...e.hu>
>> Date: Mon, 11 Aug 2008 11:11:42 +0200
>> Subject: [PATCH] net, wd.c: fix undefined reference to `NS8390p_init'
>>
>> fix:
>>
>>   drivers/built-in.o: In function `wd_probe1':
>>   wd.c:(.init.text+0xb247): undefined reference to `NS8390p_init'
>>
>> that triggers with:
>>
>>   http://redhat.com/~mingo/misc/config-Mon_Aug_11_10_40_46_CEST_2008.bad
>>
>> Signed-off-by: Ingo Molnar <mingo@...e.hu>
>> ---
>>  drivers/net/Makefile |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> DaveM should have it AFAIK, I'll double-check and make sure it got in  
> somewhere.

there's also this build failure:

 wd.c:(.text+0x38804): undefined reference to `ei_close'
 wd.c:(.text+0x38882): undefined reference to `ei_open'
 wd.c:(.init.text+0x4952): undefined reference to `ei_interrupt'
 wd.c:(.init.text+0x4c27): undefined reference to `ei_poll'
 (.init.text+0x4c83): undefined reference to `__alloc_ei_netdev'

which are only defined in 8390.c.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html