netdev - Re: qdisc and down links (regression)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080811103405.7c096f6d@extreme>
Date:	Mon, 11 Aug 2008 10:34:05 -0700
From:	Stephen Hemminger <stephen.hemminger@...tta.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, linux-kernel@....kernel.org
Subject: Re: qdisc and down links (regression)

On Fri, 08 Aug 2008 23:24:27 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

> From: Stephen Hemminger <stephen.hemminger@...tta.com>
> Date: Fri, 8 Aug 2008 14:32:01 -0700
> 
> > It fixes it for qdisc but not for ingress filters
> > 
> > # tc qdisc add dev eth0 handle ffff: ingress
> > # tc filter add dev eth0 parent ffff: protocol ip \
> >    prio 50 u32 match ip src 0.0.0.0/0 police rate 800kbit burst 10k drop flowid :1
> > RTNETLINK answers: Invalid argument
> > We have an error talking to the kernel
> > 
> > Another problem is that the ingress qdisc can no longer be deleted
> > successfully.
> 
> These problems should be fixed by the following patch which
> I've just pushed to net-2.6:
> 
> pkt_sched: Fix ingress deletion and filter attachment.
> 
> Based upon bug reports by Stephen Hemminger.
> 
> We still had some cases using ->qdisc instead of ->qdisc_sleeping.
> 
> Also, qdisc_lookup() should return ingress qdiscs.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>

Thanks, all fixed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html