netdev - Re: [PATCH 2/2] tun: fallback if skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200808131324.56071.rusty@rustcorp.com.au>
Date:	Wed, 13 Aug 2008 13:24:55 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	netdev@...r.kernel.org, Max Krasnyansky <maxk@...lcomm.com>
Subject: Re: [PATCH 2/2] tun: fallback if skb_alloc() fails on big packets

On Tuesday 12 August 2008 20:14:09 Herbert Xu wrote:
> On Tue, Aug 12, 2008 at 04:25:53PM +1000, Rusty Russell wrote:
> > skb_alloc produces linear packets (using kmalloc()).  That can fail,
> > so should we fall back to making paged skbs.
>
> I'm not sure that this is really a good idea.  If anything then
> tries to expand the head of this skb, they may fail and be forced
> to drop the packet.

Yes, but it's no worse than now.  virtio_net keeps a cache of allocated pages, 
but that's more code; and if I'm going to generalize that I really should 
create a shrinker callback, which produces locking issues.

So I decided this was probably enough for this merge window.
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html