netdev - [PATCH] pkt_sched: Fix unlocking in tc_ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080814232708.GB2517@ami.dom.local>
Date:	Fri, 15 Aug 2008 01:27:09 +0200
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Denys Fedoryshchenko <denys@...p.net.lb>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>
Subject: [PATCH] pkt_sched: Fix unlocking in tc_ctl_tfilter()

On Fri, Aug 15, 2008 at 01:56:49AM +0300, Denys Fedoryshchenko wrote:
> Aug 15 01:54:49 194.146.153.146 [   57.428359]
> Aug 15 01:54:49 194.146.153.146 [   57.428449] 
> =============================================
> Aug 15 01:54:49 194.146.153.146 [   57.428692] [ INFO: possible recursive 
> locking detected ]
> Aug 15 01:54:49 194.146.153.146 [   57.429018] 2.6.27-rc3-git2-build-0030 #7
...

I hope this is it... otherwise I'll be back "tomorrow".

Thanks again,
Jarek P.
------------------->

pkt_sched: Fix unlocking in tc_ctl_tfilter()

Fix a bug with spin_lock_bh() inserted instead of spin_unlock_bh() by
some recent patch. 


Reported-by: Denys Fedoryshchenko <denys@...p.net.lb>
Signed-off-by: Jarek Poplawski <jarkao2@...il.com>

---

 net/sched/cls_api.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index d2b6f54..5cafdd4 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -280,7 +280,7 @@ replay:
 		if (n->nlmsg_type == RTM_DELTFILTER && t->tcm_handle == 0) {
 			spin_lock_bh(root_lock);
 			*back = tp->next;
-			spin_lock_bh(root_lock);
+			spin_unlock_bh(root_lock);
 
 			tfilter_notify(skb, n, tp, fh, RTM_DELTFILTER);
 			tcf_destroy(tp);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html