netdev - Re: [PATCH] ipvs: Create init functions for estimator code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080814045200.GD13993@verge.net.au>
Date:	Thu, 14 Aug 2008 14:52:02 +1000
From:	Simon Horman <horms@...ge.net.au>
To:	Sven Wegener <sven.wegener@...aler.net>
Cc:	netdev@...r.kernel.org, lvs-devel@...r.kernel.org,
	wensong@...ux-vs.org, ja@....bg
Subject: Re: [PATCH] ipvs: Create init functions for estimator code

On Thu, Aug 14, 2008 at 12:47:16AM +0200, Sven Wegener wrote:
> Commit 8ab19ea36c5c5340ff598e4d15fc084eb65671dc ("ipvs: Fix possible deadlock
> in estimator code") fixed a deadlock condition, but that condition can only
> happen during unload of IPVS, because during normal operation there is at least
> our global stats structure in the estimator list. The mod_timer() and
> del_timer_sync() calls are actually initialization and cleanup code in
> disguise. Let's make it explicit and move them to their own init and cleanup
> function.
> 
> Signed-off-by: Sven Wegener <sven.wegener@...aler.net>

I like the simplification that this change brings.

Acked-by: Simon Horman <horms@...ge.net.au>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html