netdev - Re: [PATCH / RFC] net: fix locking in ibm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080814073319.GA8716@Chamillionaire.breakpoint.cc>
Date:	Thu, 14 Aug 2008 09:33:19 +0200
From:	Sebastian Siewior <sebastian@...akpoint.cc>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	Sebastian Siewior <bigeasy@...utronix.de>, netdev@...r.kernel.org,
	linuxppc-dev@...abs.org, Valentine Barshak <vbarshak@...mvista.com>
Subject: Re: [PATCH / RFC] net: fix locking in ibm_newemac

* Benjamin Herrenschmidt | 2008-08-14 13:45:54 [+1000]:

>> The fix is to defer phy init until netdevice is registered / initialized.
>
>I think it's better instead to take the dev_mc_add() statement
>out of emac_configure().
I looked yesterday into that code and I saw that dev_mc_add() was called
by the network core itself. Now I'm sure it was definitly too late for
writing patches :)

>What about this patch instead, does it fix it for you ?
yep it does.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html