netdev - Re: [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48A3F07E.8000808@garzik.org>
Date:	Thu, 14 Aug 2008 04:44:46 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	roel kluin <roel.kluin@...il.com>
CC:	jie.yang@...eros.com, jgarzik@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST?

roel kluin wrote:
> untested, is it right?
> ---
> WAKE_MCAST bit tested twice, test WAKE_UCAST first.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> diff --git a/drivers/net/atl1e/atl1e_ethtool.c b/drivers/net/atl1e/atl1e_ethtool.c
> index cdc3b85..619c658 100644
> --- a/drivers/net/atl1e/atl1e_ethtool.c
> +++ b/drivers/net/atl1e/atl1e_ethtool.c
> @@ -355,7 +355,7 @@ static int atl1e_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)
>  	struct atl1e_adapter *adapter = netdev_priv(netdev);
>  
>  	if (wol->wolopts & (WAKE_ARP | WAKE_MAGICSECURE |
> -			    WAKE_MCAST | WAKE_BCAST | WAKE_MCAST))
> +			    WAKE_UCAST | WAKE_MCAST | WAKE_BCAST))
>  		return -EOPNOTSUPP;
>  	/* these settings will always override what we currently have */

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html