netdev - Re: [PATCH 6/7] netxen: add module parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48A3F0E0.6060006@garzik.org>
Date:	Thu, 14 Aug 2008 04:46:24 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Dhananjay Phadke <dhananjay@...xen.com>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 6/7] netxen: add module parameters

Dhananjay Phadke wrote:
> Add user tunable params to enable/disable msi/msix, port auto-neg modes.
> 
> Signed-off-by: Dhananjay Phadke <dhananjay@...xen.com>
> ---
>  drivers/net/netxen/netxen_nic_main.c |   10 +++++++++-
>  1 files changed, 9 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
> index 3c424a8..ee56511 100644
> --- a/drivers/net/netxen/netxen_nic_main.c
> +++ b/drivers/net/netxen/netxen_nic_main.c
> @@ -50,13 +50,21 @@ static char netxen_nic_driver_string[] = "NetXen Network Driver version "
>      NETXEN_NIC_LINUX_VERSIONID;
>  
>  static int port_mode = NETXEN_PORT_MODE_AUTO_NEG;
> +module_param(port_mode, int, 0);
> +MODULE_PARM_DESC(port_mode, "Force port mode Auto-Neg XG, 1G or XG");
>  
>  /* Default to restricted 1G auto-neg mode */
> -static int wol_port_mode = 5;
> +static int wol_port_mode = NETXEN_PORT_MODE_AUTO_NEG_1G;
> +module_param(wol_port_mode, int, 0);
> +MODULE_PARM_DESC(wol_port_mode, "Force WOL port mode XG, 1G or Auto-Neg");
>  
>  static int use_msi = 1;
> +module_param(use_msi, bool, 0);
> +MODULE_PARM_DESC(use_msi, "Enable or disable MSI interrupts");
>  
>  static int use_msi_x = 1;
> +module_param(use_msi_x, bool, 0);
> +MODULE_PARM_DESC(use_msi_x, "Enable or disable MSI-X interrupts");

typically it is preferred not add module parameters for each type of 
setting.  drivers should auto-configure themselves, modulo PCI quirks 
and the like.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html