[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f4845fc0808140722j78698483wcf8d7a4b6bc5cc5a@mail.gmail.com>
Date: Thu, 14 Aug 2008 16:22:33 +0200
From: "Julius Volz" <juliusv@...gle.com>
To: "Sven Wegener" <sven.wegener@...aler.net>
Cc: netdev@...r.kernel.org, lvs-devel@...r.kernel.org,
horms@...ge.net.au, kaber@...sh.net, davem@...emloft.net,
tgraf@...g.ch, vbusam@...gle.com
Subject: Re: [PATCHv3 2/2] IPVS: Add genetlink interface implementation
On Thu, Aug 14, 2008 at 3:32 PM, Sven Wegener <sven.wegener@...aler.net> wrote:
> On Thu, 14 Aug 2008, Julius Volz wrote:
>> Ok, fixed this up. The mutex is not completely moved down to make the
>> code look a bit nicer (nla_put_failure assumes locked mutex). There
>> should not be much concurrency anyways since this mutex only locks the
>> userspace interface, which is mainly used by ipvsadm.
>
> True, it was just a hint for an optimization. Looks good to me.
>
> Acked-by: Sven Wegener <sven.wegener@...aler.net>
Thanks for the help with this!
> Should we get this into 2.6.27? It's a new interface, currently unused, so
> the chance of breaking anything is marginal.
Yeah, it shouldn't break anything existing and that would be great!
Julius
--
Google Switzerland GmbH
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists