netdev - Re: [PATCH 1/2] netns: fix NULL-dereference in dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48A49599.40307@hp.com>
Date:	Thu, 14 Aug 2008 16:29:13 -0400
From:	Brian Haley <brian.haley@...com>
To:	"Denis V. Lunev" <den@...allels.com>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	containers <containers@...ts.osdl.org>
Subject: Re: [PATCH 1/2] netns: fix NULL-dereference in dev_net()

Denis V. Lunev wrote:
> On Thu, 2008-08-14 at 15:27 -0400, Brian Haley wrote:
>> Change dev_net() to handle a NULL argument - return &init_net instead.
>>
>> -Brian
>>
>> Signed-off-by: Brian Haley <brian.haley@...com>
>> ---
>>
> the code is designed keeping in mind that there are no checks for
> 	net != NULL
> in any place. They are too expensive. We need to invent other way :(

Ok, I'll fix the other callers to pass *net, I was just trying to be 
overly safe in dev_net() to avoid a crash.

-Brian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html